Open
Conversation
Collaborator
ElliottKasoar
left a comment
ElliottKasoar
left a comment
There was a problem hiding this comment.
Thanks for this! I need to test is properly, but from a first pass of the code it looks great!
I know they're relatively small, but are you happy for me to upload the data start files to the S3 bucket, just to slim things down?
ml_peg/calcs/physicality/oxidation_states/calc_oxidation_states.py
Outdated
Show resolved
Hide resolved
ml_peg/analysis/physicality/oxidation_states/analyse_oxidation_states.py
Outdated
Show resolved
Hide resolved
ml_peg/calcs/physicality/oxidation_states/calc_oxidation_states.py
Outdated
Show resolved
Hide resolved
Collaborator
|
I think the plot titles/axes aren't quite working. Since the plots are unique to each model, it would also be nice to include the model name somewhere in the title, if possible. 
|
…ation function - edited to remove unecessary data files
Co-authored-by: Elliott Kasoar <45317199+ElliottKasoar@users.noreply.github.com>
…tor and edited the analysis script accordingly
PKourtis
force-pushed
the
oxidation_states_clean
branch
from
9bba7fa to
fb343dc
Compare
… skipped if the MD trajs are not present
…e form of outputs / model / {salt}-traj.extxyz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
Benchmarks how well models capture the different oxidation states of Iron.
Main tests compares the O-Fe RDFs of Fe+2 and Fe+3 by running 20ps NVT MD for Fe 2Cl and Fe 3Cl ions in water.
Linked issue
Resolves #264
Progress
Testing
Tested on mp0-b3, currently running omol-0 MD.
New decorators/callbacks
Added new option to the plot_scatter decorator to remove markers from the plots.